Use absolute error instead of average error for path check

diff --git a/babl/babl-fish-path.c b/babl/babl-fish-path.c
index ebf2cb5b7e69f3f8cfb3ea489cefe6088f00d06b..82838e96ab27b59b33f2f080b132e778ca12c69e 100644 (file)
--- a/babl/babl-fish-path.c
+++ b/babl/babl-fish-path.c
@@ -708,9 +708,9 @@ get_path_instrumentation (FishPathInstrumentation *fpi,
   babl_process (fpi->fish_destination_to_rgba,
                 fpi->destination, fpi->destination_rgba_double, NUM_TEST_PIXELS);
 
-  *path_error = babl_rel_avg_error (fpi->destination_rgba_double,
-                                    fpi->ref_destination_rgba_double,
-                                    NUM_TEST_PIXELS * 4);
+  *path_error = babl_abs_error (fpi->destination_rgba_double,
+                                fpi->ref_destination_rgba_double,
+                                NUM_TEST_PIXELS * 4);
 
 #if 0
   fpi->fish_rgba_to_source->fish.processings--;

diff --git a/babl/babl-util.c b/babl/babl-util.c
index 92977ac8ca7bda662ee704b8754451a3c12ca6ac..f99b54bd95546397c59d7e9bbf3425d234506dbf 100644 (file)
--- a/babl/babl-util.c
+++ b/babl/babl-util.c
@@ -88,9 +88,28 @@ babl_process_cost (long ticks_start,
 }
 
 double
-babl_rel_avg_error (double *imgA,
-                    double *imgB,
-                    long    samples)
+babl_abs_error (const double *imgA,
+                const double *imgB,
+                long          samples)
+{
+  double abs_error = 0.0;
+  long   i;
+
+  for (i = 0; i < samples; i++)
+    {
+      double sample_error = fabs (imgA[i] - imgB[i]);
+
+      if (sample_error > abs_error)
+        abs_error = sample_error;
+    }
+
+  return abs_error;
+}
+
+double
+babl_rel_avg_error (const double *imgA,
+                    const double *imgB,
+                    long          samples)
 {
   double error = 0.0;
   long   i;

diff --git a/babl/babl-util.h b/babl/babl-util.h
index bdaeec81351eb5cc46549c811348f79078309c08..8c49619ea41748d6961292e9472dc5f4466a719f 100644 (file)
--- a/babl/babl-util.h
+++ b/babl/babl-util.h
@@ -27,7 +27,12 @@ babl_process_cost (long ticks_start,
                    long ticks_end);
 
 double
-babl_rel_avg_error (double *imgA,
-                    double *imgB,
-                    long    samples);
+babl_rel_avg_error (const double *imgA,
+                    const double *imgB,
+                    long          samples);
+
+double
+babl_abs_error     (const double *imgA,
+                    const double *imgB,
+                    long          samples);
 #endif